Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of gozer@ectoplasm.org designates
 66.34.202.202 as permitted sender)
Message-ID: <441B56A6.80309@ectoplasm.org>
Date: Fri, 17 Mar 2006 16:39:02 -0800
From: "Philippe M. Chiasson" <gozer@ectoplasm.org>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
MIME-Version: 1.0
To: dev@perl.apache.org
CC: Randy Kobes <randy@theoryx5.uwinnipeg.ca>
Subject: add_config() and thread-safety
Content-Type: multipart/signed; micalg=pgp-ripemd160;
 protocol="application/pgp-signature";
 boundary="------------enig87B510239B5F35773EAF5BEA"

--------------enig87B510239B5F35773EAF5BEA
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

I've been looking at the failure Randy reported with t/api/add_config failing
when run multiple times.

Took a while, but I finally got my eyes open today. It's an issue of thread-safety
that was completely overlooked.

Trying to do something like:

$r->add_config(['<Location /foo>',[...],'</Location>']);

Is not, and cannot be thread-safe, as it needs to access the server's core config
at one point, leading to all sort of nastyness.

Another way to achieve the same thing is with:

$r->server->add_config()

At request-time.

With preform, this will work, but obviously, only affect the current child process.

In my opinion, this is way *wrong* and needs to be fixed. Similarly to how .htaccess
files work, you should only be able to affect configuration of the current request
when using add_config() at request time.

It's been fixed/implemented in r386774. (It's not documented yet, patches welcome)

Randy, I'd like to know if your test failure dissapears with this change.

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

--------------enig87B510239B5F35773EAF5BEA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFEG1auyzKhB4jDpaURA6scAJ4/+9IZRsPybZAtpUHuI6ODL/my3QCgiDg9
YbfCQw130BiQaQrSgyzM6Po=
=Dwhn
-----END PGP SIGNATURE-----

--------------enig87B510239B5F35773EAF5BEA--