Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <440F9116.8090307@modperlcookbook.org>
Date: Wed, 08 Mar 2006 21:21:10 -0500
From: Geoffrey Young <geoff@modperlcookbook.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040927
MIME-Version: 1.0
To: "Philippe M. Chiasson" <gozer@ectoplasm.org>
CC: Frank Wiles <frank@wiles.org>, dev@perl.apache.org
Subject: Re: confusing error message patch
References: <20060307191741.7c348116.frank@wiles.org>
 <440F8ECA.1080607@ectoplasm.org>
In-Reply-To: <440F8ECA.1080607@ectoplasm.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit


Philippe M. Chiasson wrote:
> Frank Wiles wrote:
> 
>>  Hey Everyone, 
>>
>>  Saw the thread about $r->read($buf,0) and figured it would be wise
>>  to fix the error message to keep someone else from getting confused. 
>>
>>  Here is a small patch to change "The LENGTH argument can't be
>>  negative" to "The LENGTH argument can't be negative or zero".  
> 
> 
> How about one of these ?
> 
> "The LENGTH argument must be a positive number"
> "The LENGTH argument must be > 0"
> "The LENGTH argument must be >= 1"
> "The LENGTH argument must be greater than zero"

have we actually demonstrated that $r->read($buf,0) is an error?  almost
definitely useless, sure, but an error?  or maybe the problem is a loop
might read and return true indefinitely, so

  while ($r->read($buf,$len)) { ... }

would be bad?

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org