Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 76650 invoked from network); 9 Mar 2006 02:11:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 9 Mar 2006 02:11:48 -0000 Received: (qmail 85044 invoked by uid 500); 9 Mar 2006 02:11:48 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 85019 invoked by uid 500); 9 Mar 2006 02:11:47 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 85008 invoked by uid 99); 9 Mar 2006 02:11:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2006 18:11:47 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of gozer@ectoplasm.org designates 66.34.202.202 as permitted sender) Received: from [66.34.202.202] (HELO minerva.ectoplasm.org) (66.34.202.202) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2006 18:11:46 -0800 Received: from minerva.ectoplasm.org (localhost.localdomain [127.0.0.1]) by pmx.secure.ectoplasm.org (Postfix) with SMTP id 179B35F533; Wed, 8 Mar 2006 18:11:26 -0800 (PST) Received: from [192.168.10.200] (unknown [192.168.10.200]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by minerva.ectoplasm.org (Postfix) with ESMTP id D153C5F522; Wed, 8 Mar 2006 18:11:25 -0800 (PST) Message-ID: <440F8ECA.1080607@ectoplasm.org> Date: Wed, 08 Mar 2006 18:11:22 -0800 From: "Philippe M. Chiasson" User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Frank Wiles CC: dev@perl.apache.org Subject: Re: confusing error message patch References: <20060307191741.7c348116.frank@wiles.org> In-Reply-To: <20060307191741.7c348116.frank@wiles.org> X-Enigmail-Version: 0.91.0.0 Content-Type: multipart/signed; micalg=pgp-ripemd160; protocol="application/pgp-signature"; boundary="------------enig56478F97C83044ED30E30D7C" X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --------------enig56478F97C83044ED30E30D7C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Frank Wiles wrote: > Hey Everyone, > > Saw the thread about $r->read($buf,0) and figured it would be wise > to fix the error message to keep someone else from getting confused. > > Here is a small patch to change "The LENGTH argument can't be > negative" to "The LENGTH argument can't be negative or zero". How about one of these ? "The LENGTH argument must be a positive number" "The LENGTH argument must be > 0" "The LENGTH argument must be >= 1" "The LENGTH argument must be greater than zero" -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5 --------------enig56478F97C83044ED30E30D7C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFED47LyzKhB4jDpaURA357AKCSOB873eB/r7lUbjIrF9H2ZwIulACfWtby v9RIEj47QXwoMN3yTBEREQ8= =ZmEF -----END PGP SIGNATURE----- --------------enig56478F97C83044ED30E30D7C--