perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: Connection pnotes
Date Sat, 18 Mar 2006 01:33:33 GMT
Geoffrey Young wrote:
>>This seems to make the problem go away, but I am not sure if that's where it
>>belongs:
>>
>>sub handler {
>>
>>    my $r = shift;
>>
>>    # make it ok to call ok() here while plan()ing elsewhere
>>    Apache::Test::init_test_pm($r);
>>
>>+   Test::_reset_globals() if Test->can('_reset_globals');
>>    $Test::ntest   = 1 + (22 * ($r->args - 1));
>>    $Test::planned = 22;
> 
> gozer++
> 
>>
>>>it will probably be easier for me to muck with the tests once they are
>>>committed.  to that end, let's get the functionality to where it needs to be
>>>then I'll work on recreating and removing the warnings.
>>
>>If the patch looks good to you, I'll check it in and we should be good.
> 
> yeah, go ahead.

We now have connection pnotes as of r386784.

Documentation patch is still necessary.

>>Oh, and I forgot one other benefit of the patch, it merges in the pool cleanup
>>patch I send before, removing the pnotes cleanup from mod_perl's guts and into
>>a pool cleanup only when used.
> 
> excellent.  way to find the tuits, philippe.

I do what I can ;-)

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message