Return-Path: 
 <dev-return-11544-apmail-perl-dev-archive=perl.apache.org@perl.apache.org>
Delivered-To: apmail-perl-dev-archive@www.apache.org
Received: (qmail 80508 invoked from network); 25 Jan 2006 01:17:00 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 25 Jan 2006 01:17:00 -0000
Received: (qmail 94746 invoked by uid 500); 25 Jan 2006 01:16:59 -0000
Delivered-To: apmail-perl-dev-archive@perl.apache.org
Received: (qmail 94731 invoked by uid 500); 25 Jan 2006 01:16:59 -0000
Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@perl.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@perl.apache.org>
List-Post: <mailto:dev@perl.apache.org>
List-Id: <dev.perl.apache.org>
Delivered-To: mailing list dev@perl.apache.org
Received: (qmail 94718 invoked by uid 99); 25 Jan 2006 01:16:59 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2006 17:16:59 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [66.77.29.165] (HELO secure.exclamationlabs.net) (66.77.29.165)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2006 17:16:57 -0800
Received: from [192.168.2.160] (pcp0010776620pcs.walngs01.pa.comcast.net
 [69.141.1.101])
	(authenticated (0 bits))
	by secure.exclamationlabs.net (8.11.6/8.11.6) with ESMTP id k0P1GdK25972;
	Tue, 24 Jan 2006 19:16:39 -0600
Message-ID: <43D6D171.7060503@modperlcookbook.org>
Date: Tue, 24 Jan 2006 20:16:33 -0500
From: Geoffrey Young <geoff@modperlcookbook.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040927
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Stas Bekman <stas@stason.org>
CC: dev@perl.apache.org
Subject: Re: svn commit: r371915 - in /perl/modperl/trunk/t:
 conf/extra.last.conf.in
 hooks/TestHooks/startup.pm
References: <20060124135542.4319.qmail@minotaur.apache.org>
 <43D6CA5D.8000503@stason.org>
In-Reply-To: <43D6CA5D.8000503@stason.org>
X-Enigmail-Version: 0.86.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N



Stas Bekman wrote:
> geoff@apache.org wrote:
> 
>> Author: geoff
>> Date: Tue Jan 24 05:55:39 2006
>> New Revision: 371915
>>
>> URL: http://svn.apache.org/viewcvs?rev=371915&view=rev
>> Log:
>> add simple tests to make sure $ENV{MOD_PERL}
>> and $ENV{MOD_PERL_API_VERSION} are set as soon
>> as possible
>>
>> Modified:
>>     perl/modperl/trunk/t/conf/extra.last.conf.in
>>     perl/modperl/trunk/t/hooks/TestHooks/startup.pm
>>
>> Modified: perl/modperl/trunk/t/conf/extra.last.conf.in
>> URL:
>> http://svn.apache.org/viewcvs/perl/modperl/trunk/t/conf/extra.last.conf.in?rev=371915&r1=371914&r2=371915&view=diff
>>
>> ==============================================================================
>>
>> --- perl/modperl/trunk/t/conf/extra.last.conf.in (original)
>> +++ perl/modperl/trunk/t/conf/extra.last.conf.in Tue Jan 24 05:55:39 2006
>> @@ -67,6 +67,13 @@
>>  $TestDirective::perl::base_server = Apache2::PerlSections->server;
>>  </Perl>
>>  
>> +<Perl >
>> +# make sure that these are set at the earliest possible time
>> +die '$ENV{MOD_PERL} not set!' unless $ENV{MOD_PERL};
>> +die '$ENV{MOD_PERL_API_VERSION} not set!'
>> +    unless $ENV{MOD_PERL_API_VERSION} == 2;
>> +</Perl>
>> +
> 
> 
> The only issue here is that Apache ignores any failures in the mp land
> at the server startup and it'll still start regardless.

that isn't what I observed - I put a die in there and the other place and
the server didn't start.  granted, the error message wasn't all that
informative, but it did keep the server from starting... at least with the
apache I tested :)

> But as we know
> this die shouldn't happen I guess it's OK. (and of course everybody
> observes error_log during the test suite run :)

actually, I couldn't get the open_logs handler to spit errors to the
error_log, which I guess is kinda the risk you run when messing around with
that phase...

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org