Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of gozer@ectoplasm.org designates
 66.34.202.202 as permitted sender)
Message-ID: <43CE93EE.7010205@ectoplasm.org>
Date: Wed, 18 Jan 2006 11:15:58 -0800
From: "Philippe M. Chiasson" <gozer@ectoplasm.org>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
MIME-Version: 1.0
To: Stas Bekman <stas@stason.org>
CC: mod_perl Dev <dev@perl.apache.org>
Subject: Re: [mp2 patch] accessors for User and Group directives in httpd.conf
References: <43CC4437.4050100@stason.org>
In-Reply-To: <43CC4437.4050100@stason.org>
Content-Type: multipart/signed; micalg=pgp-ripemd160;
 protocol="application/pgp-signature";
 boundary="------------enig19C8222F01C5913F17A487D6"

--------------enig19C8222F01C5913F17A487D6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Stas Bekman wrote:
> I've added accessors to Group and User directives in httpd.conf, so that
> now you can get that info via:
> 
>   my $user_id  = Apache2::ServerUtil->user_id;
>   my $group_id = Apache2::ServerUtil->group_id;
> 
> the patch is inlined and attached (due to long lines).
> 
> Please let me know if you are happy with this approach or you want it to
> be different. (including the test).

I am not sure why the test is called apache/deamon ?

> Another concern is windows - so if someone can try to build with this
> patch on windows that would be great.

Patch looks good, at least on Linux/OSX it passes all tests 100%.
It certainly would be nice to get feedback for win32 platforms before
checking it in. Otherwise, I think it's a good idea.

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

--------------enig19C8222F01C5913F17A487D6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFDzpPuyzKhB4jDpaURA/p1AKC3yoZulx085hEn3yO/M1diupipbACgjafx
yJAZoU/qmuz345+nVAMyfPM=
=FteH
-----END PGP SIGNATURE-----

--------------enig19C8222F01C5913F17A487D6--