perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [PATCH] Apache2::RequestUtil->add_config
Date Sat, 07 Jan 2006 09:17:20 GMT
Torsten Foertsch wrote:
> Hi,
> 
> the patch below solves the following situation.
> 
> The ProxyPassReverse directive is outside any <Location> block given as
> 
>   ProxyPassReverse /path http://...
> 
> but inside a Location block without the /path specification:
> 
>   <Location /path>
>   ProxyPassReverse http://...
>   </Location>
> 
> In the latter case the path is taken from $parms->path, that means the path of 
> the Location block.
> 
> Since $r->add_config([@lines]) is literally a
> 
>   <Location />
>   @lines
>   </Location>

Well, it's not exactly that, literally, but, yup, it's close enough.

> ProxyPassReverse cannot be applied with $r->add_config for a path other than 
> "/".

Well, you could do add_config(
<Location /path>
  ProxyPassReverse http://...
</Location>);

No ?

> The patch adds an optional 3rd parameter to $r->add_config that lets you pass 
> in the path.
> 
> I don't think ProxyPassReverse is the only directive that behaves this way.

As a more generic solution, this might make sense. On first glance, your patch
looks sane, but I won't have the time to really look at it until Jan 15th, so
if anybody else feels like writing a few tests for this and beat me to it...

-- 
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message