perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: svn commit: r357236 - /perl/modperl/trunk/src/modules/perl/modperl_env.c
Date Sat, 17 Dec 2005 02:52:49 GMT
Philippe M. Chiasson wrote:
> Stas Bekman wrote:
> 
>>gozer@apache.org wrote:
>>
>>
>>>Author: gozer
>>>Date: Fri Dec 16 13:20:23 2005
>>>New Revision: 357236
>>>
>>>URL: http://svn.apache.org/viewcvs?rev=357236&view=rev
>>>Log:
>>>"local %ENV;" caused Segmentation fault in modperl_env_request_tie()
>>>
>>>Reported-By:  Peter Walsham <peter@axomic.com>
>>>Thread: http://thread.gmane.org/gmane.comp.apache.mod-perl/22236
>>
>>a bug fix w/o adding a test?
> 
> 
> Well, the test would cause a segfault, so figured it wasn't such a good idea
> to add it. But now that the fix is in, I guess I could make a test case to make
> sure it now works. Good point Stas ;-)
> 
> Expect test case soon.

Commited r357282 with a simplistic test that would cause that segfault if the
bug is ever re-introduced.

> Which reminds me, it would be nice to have a bug/ test categorie for such gems
> that don't fit very nicely anywhere else.

How's t/bugs/ sound for bits like this one ?

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message