perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [PATCH] stop defining AP_HAVE_DESIGNATED_INITIALIZER/AP_DEBUG
Date Fri, 16 Dec 2005 16:12:23 GMT

> OK thanks.  Now I see this causes a regression in the 2.0 build with 
> MP_MAINTAINER=1! Sorry about that :(
> 
> The problem is really just that AP_HAVE_DESIGNATED_INITIALIZER does not 
> get picked up through apxs because it was defined in the wrong place in 
> httpd in the first place; it's in the obscure NOTEST_CPPFLAGS.
> 
> So this fixes that:
> 
> Index: lib/Apache2/Build.pm
> ===================================================================
> --- lib/Apache2/Build.pm	(revision 357155)
> +++ lib/Apache2/Build.pm	(working copy)
> @@ -227,7 +227,8 @@
>  
>  sub apxs_extra_cppflags {
>      my $who = caller_package(shift);
> -    my $flags = $who->apxs('-q' => 'EXTRA_CPPFLAGS');
> +    my $flags = $who->apxs('-q' => 'EXTRA_CPPFLAGS') ." ".
> +        $who->apxs('-q' => 'NOTEST_CPPFLAGS');
>      $flags =~ s/\"/\\\"/g;
>      $flags;
>  }

thanks, committed.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message