perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [PATCH] stop defining AP_HAVE_DESIGNATED_INITIALIZER/AP_DEBUG
Date Tue, 13 Dec 2005 14:42:25 GMT


Joe Orton wrote:
> Does anyone know why mod_perl is defining AP_HAVE_DESIGNATED_INITIALIZER 
> and AP_DEBUG for debug builds?  (I'd check the history but minotaur is 
> down again)

I would assume it's because we want MP_MAINTAINER to enable the same
switches for mod_perl as --with-maintainer-mode does for httpd.

> 
> These are really up to httpd to define, or not.  On the trunk (and 
> hopefully soon also 2.2.x), AP_HAVE_DESIGNATED_INITIALIZER is defined in 
> ap_config.h, so this is producing myriad build warnings/failures with 
> -Werror for MP_MAINTAINER=1 builds.

ok, my compile-fu is so bad I need to ask the answer to this...

will including ap_config.h during the normal build process trigger the
defines for when mod_perl is built without those switches?  I'm guessing it
does otherwise it wouldn't throw those warnings you're seeing...

in all, I think all we need to do is make sure that MP_MAINTAINER=1 enables
code like this, however that is accomplished

  modperl_module.c [528]: #if defined(AP_HAVE_DESIGNATED_INITIALIZER)

maybe we need to change that to

  modperl_module.c [528]: #if defined(MP_HAVE_DESIGNATED_INITIALIZER)

?  I mean, if we want MP_MAINTAINER to enable mod_perl maintainer hooks
independently of httpd.  not sure if that even makes sense, though...

--Geoff

> 
> --- ./lib/Apache2/Build.pm.orig	2005-12-13 10:37:41.000000000 +0000
> +++ ./lib/Apache2/Build.pm	2005-12-13 10:43:27.000000000 +0000
> @@ -522,11 +522,6 @@
>  
>      if ($self->{MP_MAINTAINER}) {
>          $self->{MP_DEBUG} = 1;
> -        if ($self->perl_config('gccversion')) {
> -            #same as --with-maintainter-mode
> -            $ccopts .= " $Wall -DAP_DEBUG";
> -            $ccopts .= " -DAP_HAVE_DESIGNATED_INITIALIZER";
> -        }
>  
>          if ($self->has_gcc_version('3.3.2') && 
>              $ccopts !~ /declaration-after-statement/) {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message