perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject [PATCH] stop defining AP_HAVE_DESIGNATED_INITIALIZER/AP_DEBUG
Date Tue, 13 Dec 2005 10:46:57 GMT
Does anyone know why mod_perl is defining AP_HAVE_DESIGNATED_INITIALIZER 
and AP_DEBUG for debug builds?  (I'd check the history but minotaur is 
down again)

These are really up to httpd to define, or not.  On the trunk (and 
hopefully soon also 2.2.x), AP_HAVE_DESIGNATED_INITIALIZER is defined in 
ap_config.h, so this is producing myriad build warnings/failures with 
-Werror for MP_MAINTAINER=1 builds.

--- ./lib/Apache2/Build.pm.orig	2005-12-13 10:37:41.000000000 +0000
+++ ./lib/Apache2/Build.pm	2005-12-13 10:43:27.000000000 +0000
@@ -522,11 +522,6 @@
 
     if ($self->{MP_MAINTAINER}) {
         $self->{MP_DEBUG} = 1;
-        if ($self->perl_config('gccversion')) {
-            #same as --with-maintainter-mode
-            $ccopts .= " $Wall -DAP_DEBUG";
-            $ccopts .= " -DAP_HAVE_DESIGNATED_INITIALIZER";
-        }
 
         if ($self->has_gcc_version('3.3.2') && 
             $ccopts !~ /declaration-after-statement/) {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message