perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject [mp2 bug] push_handlers(PostConfig...) on vhost is silently ignored
Date Wed, 23 Nov 2005 23:34:59 GMT
Configuring PostConfig phase via push_handlers on the vhost server is 
silently ignored under mp2.

For example a custom directive handler FooBar:

sub FooBar {
     my ($self, $parms, $arg) = @_;

     my $s = $parms->server;
     # XXX: calling it on the non-vhost server works
     #Apache2::ServerUtil->server->push_handlers(
     $s->push_handlers(
         PerlPostConfigHandler => \&post_config);
     ...

See the attached tarball that reproduces the problem.

I think the solution should be either change modperl_post_config_handler 
to iterate over vhosts or it should explode when a user tries to register 
the callback on a vhost server (but it'll affect the push_handlers 
run-time performance a bit), to handle the special case.

(the same issue applies to open_logs)

-- 
_____________________________________________________________
Stas Bekman mailto:stas@stason.org  http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book       http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/


Mime
View raw message