perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: [RELEASE CANDIDATE] mod_perl-2.0.2 RC1
Date Fri, 07 Oct 2005 03:37:04 GMT
On Thu, 6 Oct 2005, Randy Kobes wrote:

> On Thu, 6 Oct 2005, Geoffrey Young wrote:
>
>> 
>>> By my count, thats 2 +1s.  I'll have some A-T feedback later this weekend.
>> 
>> just as a reminder, the ASF is really trying to enforce "three +1 from pmc
>> members" prior to any official release coming from ASF projects, regardless
>> of how many +1s something gets from committers.
>> 
>> here's my +1, which makes 2 pmc votes for 2.0.2.  randy, perrin, joe?  :)
>
> I'm working on trying to find out what causes Steve's problem in running the 
> tests - he specifies MP_AP_PREFIX
> properly, but somehow the wrong Apache directory is picked
> up. This might be a problem with Apache-Test ...

I think the problem is that a fix in the current svn for
Apache::TestConfigParse didn't make it into this rc. The
diff is

==========================================================
--- TestConfigParse.pm~	Fri Sep  9 00:12:46 2005
+++ TestConfigParse.pm	Mon Oct  3 22:10:08 2005
@@ -347,14 +347,16 @@
              $file = catfile $base, $default_conf;

              # SERVER_CONFIG_FILE might be an absolute path
-            if (! -e $file && -e $default_conf) {
-                $file = $default_conf;
-            }
-            else {
-                # try a little harder
-                if (my $root = $self->{httpd_defines}->{HTTPD_ROOT}) {
-                    debug "using HTTPD_ROOT to resolve $default_conf";
-                    $file = catfile $root, $default_conf;
+            unless (-e $file) {
+                if (-e $default_conf) {
+                    $file = $default_conf;
+                }
+                else {
+                    # try a little harder
+                    if (my $root = $self->{httpd_defines}->{HTTPD_ROOT}) {
+                        debug "using HTTPD_ROOT to resolve $default_conf";
+                        $file = catfile $root, $default_conf;
+                    }
                  }
              }
          }

=====================================================================

Steve, does this fix the tests for you?

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message