perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: THREADS
Date Fri, 23 Sep 2005 06:18:39 GMT
Philip M. Gollucci wrote:
> make
> [snipped]
> cc 
> -I/usr/home/pgollucci/dev/repos/asf/perl/modperl/trunk/src/modules/perl 
> -I/usr/home/pgollucci/dev/repos/asf/perl/modperl/trunk/xs 
> -I/usr/home/pgollucci/dev/apps/httpd-2.0.54/prefork/include 
> -I/usr/home/pgollucci/dev/apps/httpd-2.0.54/prefork/include 
> -I/usr/local/include 
> -I/usr/home/pgollucci/dev/apps/httpd-2.0.54/prefork/include -pipe 
> -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -DDEBUGGING -fno-strict-aliasing 
> -I/usr/local/include -I/usr/home/pgollucci/dev/apps/perl-5.6.2/lib/CORE 
> -DMOD_PERL -Wall -Wmissing-prototypes -Wstrict-prototypes 
> -Wmissing-declarations -Werror -DAP_DEBUG 
> -DAP_HAVE_DESIGNATED_INITIALIZER -Wdeclaration-after-statement 
> -DMP_COMPAT_1X -DMP_DEBUG -DMP_TRACE -D_REENTRANT -D_THREAD_SAFE 
> -DAP_DEBUG -ggdb3 -O0 -DPIC -fPIC  -c modperl_util.c && mv 
> modperl_util.o modperl_util.lo
> modperl_util.c: In function `modperl_perl_call_list':
> modperl_util.c:474: warning: implicit declaration of function 
> `apr_os_thread_current'
> *** Error code 1

I've finally figured this out!!!!!! :)
PATCH below +/-1

apr.h always DEFINES APR_HAS_THREADS be it as 0 or 1.
Hence, defined(APR_HAS_THREADS) is always true!

So if I say MP_MAINTAINER=1 I get MP_TRACE=1 which yes is defined
and regardless how APR_HAS_THREADS is setup its defined so this expression is true.

I'll look for other occurences of this in the code.

THANK GOD!

pgollucci@pgollucci.internal.liquidation.com 
/home/pgollucci/dev/repos/asf/perl/modperl/trunk rv=0 82 >svn diff 
src/modules/perl/modperl_util.h
Index: src/modules/perl/modperl_util.h
===================================================================
--- src/modules/perl/modperl_util.h     (revision 289826)
+++ src/modules/perl/modperl_util.h     (working copy)
@@ -100,7 +100,7 @@
  apr_array_header_t *modperl_avrv2apr_array_header(pTHX_ apr_pool_t *p,
                                                    SV *avrv);
  void modperl_package_unload(pTHX_ const char *package);
-#if defined(MP_TRACE) && defined(APR_HAS_THREADS)
+#if defined(MP_TRACE) && APR_HAS_THREADS
  #define MP_TRACEf_TID   "/tid 0x%lx"
  #define MP_TRACEv_TID   (unsigned long)apr_os_thread_current()
  #define MP_TRACEv_TID_  MP_TRACEv_TID,

-- 
END
------------------------------------------------------------
     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
				
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
   http://www.liquidityservicesinc.com
        http://www.liquidation.com
        http://www.uksurplus.com
        http://www.govliquidation.com
        http://www.gowholesale.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message