perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: mp2biug and httpd TestConfigData
Date Wed, 14 Sep 2005 08:13:57 GMT
Stas Bekman wrote:
> Philip M. Gollucci wrote:
> But I don't think you should ever load it manually. It's A-T's job to do 
> that. Just leave it there and talk to A-T if you need to get hold of 
> that info.
I've pinned it down now.

./mp2bug

ModPerl::Config::as_string() ->
   Apache::TestConfig::new();

      if ($args->{thaw} and ref($thaw) ne 'HASH') {
         #dont generate any new config
         $thaw->{vars}->{$_} = $args->{$_} for keys %$args;
         $thaw->{server} = $thaw->new_test_server;
         $thaw->add_inc;
         return $thaw;
     }

We return in this IF having _never_ loaded Apache::TestConfigData.pm thus mp2bug doesn't ever
know
the path of httpd causing most of the missing info in the mp2bug reports we've seen to the
list
and my greif.

Here is an actual fix instead of a "quick hack" like my previous two attempts now that I understand
it.
Thanks for the suggestions Stas!

pgollucci@smgellar.p6m7g8.net /home/pgollucci/dev/repos/asf/perl/modperl/Apache-Test/trunk/lib/Apache
rv=0 143 >svn diff
Index: TestConfig.pm
===================================================================
--- TestConfig.pm       (revision 280754)
+++ TestConfig.pm       (working copy)
@@ -252,6 +252,7 @@
          $thaw->{vars}->{$_} = $args->{$_} for keys %$args;
          $thaw->{server} = $thaw->new_test_server;
          $thaw->add_inc;
+        custom_config_add_conf_opts($args);
          return $thaw;
      }

@@ -2153,6 +2154,8 @@
  sub custom_config_add_conf_opts {
      my $args = shift;

+    custom_config_load();
+
      return unless $Apache::TestConfigData::vars and
          keys %$Apache::TestConfigData::vars;

-- 
END
------------------------------------------------------------
     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
				
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
   http://www.liquidityservicesinc.com
        http://www.liquidation.com
        http://www.uksurplus.com
        http://www.govliquidation.com
        http://www.gowholesale.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message