perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: svn commit: r280495 - /perl/modperl/trunk/lib/ModPerl/Config.pm
Date Tue, 13 Sep 2005 21:35:09 GMT
Philip M. Gollucci wrote:
> Stas Bekman wrote:
> 
>> pgollucci@apache.org wrote:
>>
>> code duplication detected :) whenever you find yourself duplicating 
>> code you should immediately consider refactoring. Otherwise the future 
>> won't be too good... :)
>>
>> This code should live in Apache::TestConfig and used here as a 
>> function call.
> 
> I saw that actually.
> 
> ModPerl::Config::as_string and Apache::TestConfig::as_string are 
> remarkably but not quite similiar.

Please note that I've quoted the specific part of the code I was talking 
about. That part is remarkable indentical :) Just go for lower granularity.

> I going to get to mentioning that .... I was thinking pretty much all of 
> it should be in in A-T and ModPerl::Config::as_string() should just be a 
> set of function calls to the A-T implementations.

+1

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://mailchannels.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message