Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <430A1155.9010600@stason.org>
Date: Mon, 22 Aug 2005 10:54:29 -0700
From: Stas Bekman <stas@stason.org>
Organization: Hope, Humanized
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.11) Gecko/20050730
MIME-Version: 1.0
To: "Philippe M. Chiasson" <gozer@ectoplasm.org>
CC: Geoffrey Young <geoff@modperlcookbook.org>,
 "Philip M. Gollucci" <pgollucci@p6m7g8.com>,
  dev@perl.apache.org
Subject: Re: [PATCH] Apache2::Reload
References: <430845DA.6060209@p6m7g8.com>
 <4309F922.3020500@modperlcookbook.org> <430A0F06.6040303@ectoplasm.org>
In-Reply-To: <430A0F06.6040303@ectoplasm.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Philippe M. Chiasson wrote:
> Geoffrey Young wrote:
> 
>>>-    while (my($key, $file) = each %Apache2::Reload::INCS) {
>>>+    foreach my $key (sort { $a cmp $b } keys %Apache2::Reload::INCS) {
>>>+        my $file = $Apache2::Reload::INCS{$key};

>>I hate each.
> 
> 
> each is perfect when iterating over a large hash and not caring about ordering.
> Doesn't need to build a large array to hold _all_ the keys, so it's a major
> speed improvement.

right, but A-R is a dev module :) (well most of the time :)

> I am not sure what is gained here by sorting ?

Just that what Philip was after: easier to spot whether some module was 
reloaded or not.

+1

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org