perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: bugs_build TODO completed -Wdeclaration-after-statement
Date Tue, 09 Aug 2005 18:55:07 GMT
Philip M. Gollucci wrote:
> Philippe M. Chiasson wrote:
> 
>> Isn't that my ^^^ redundant ?
> 
> YES. You would have thought I would have gotten a  warning from perl.
> 
>> I suspect the version parsing could be simplified to something
>> more explicit like this :
> 
> I do too, but I'm not that familiar with GCC version numbers.  Is there
> never a case where its i.e.: 3.0 or 3?

In that case, wouldn't the split /\./, $gccversion form be sufficient ?

>> my ($maj, $min, $patch) = $gccversion =~ /^(\d+)\.(\d+)\.(\d+)/;
>>  or
>> my ($maj, $min, $patch) = split /\./, $gccversion;
>>
>> #Gcc 3.3.2 and higher
>> if ($maj >= 3 && $min >= 3 && $patch >= 2) {
>>     $ccopts .= " -Wdeclaration-after-statement";
>> }
> 
> 


-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message