perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] fix warnings with gcc 4.x
Date Tue, 19 Jul 2005 20:25:15 GMT
On Tue, Jul 19, 2005 at 08:22:23AM -0400, Geoffrey Young wrote:
> Joe Orton wrote:
> > The APR base64 encode/decode functions expect unsigned char * arguments 
> > for the raw binary input/output buffers. gcc 4.x now warns for pointer 
> > signedness mismatches like this; casting is really the only way.
> > (alternatively, if you dislike this, the warning can be turned off)
> 
> well, most of us like to build with -Werror so we keep the source as clean
> as possible, so I'd favor fixing the warning rather than simply ignoring it.

Oh yeah, I meant just adding -Wno-pointer-sign to turn off the warning.  
It's not really a useful warning in any case that I know of so there's a 
reasonable argument that the cure (silly casts) is worse than disease.

> > Also the mpxs_APR__Base64_encode_len looks rather wrong; fixed below.
> 
> great, thanks, applied.

Thanks Geoff.

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message