Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 74753 invoked from network); 21 May 2005 19:59:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 21 May 2005 19:59:50 -0000 Received: (qmail 56064 invoked by uid 500); 21 May 2005 19:59:49 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 55991 invoked by uid 500); 21 May 2005 19:59:48 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 55927 invoked by uid 99); 21 May 2005 19:59:48 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from theoryx5.uwinnipeg.ca (HELO theoryx5.uwinnipeg.ca) (142.132.65.108) by apache.org (qpsmtpd/0.28) with ESMTP; Sat, 21 May 2005 12:59:46 -0700 Received: from theoryx5.uwinnipeg.ca (localhost.localdomain [127.0.0.1]) by theoryx5.uwinnipeg.ca (8.12.8/8.12.8) with ESMTP id j4LJt5H3024816 for ; Sat, 21 May 2005 14:55:05 -0500 Received: from localhost (randy@localhost) by theoryx5.uwinnipeg.ca (8.12.8/8.12.8/Submit) with ESMTP id j4LJt5k5024812 for ; Sat, 21 May 2005 14:55:05 -0500 Date: Sat, 21 May 2005 14:55:05 -0500 (CDT) From: Randy Kobes To: dev@perl.apache.org Subject: utime on Win32 Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N In t/lib/TestAPR/finfo.pm, for Win32, utime undef, undef, $file; is used. However, with perl-5.8.0, this leads to a warning about an uninitialized value being used, causing the finfo tests to fail. This apparently is a bug in 5.8.0, as it's OK with 5.8.6. Would the following patch be OK? ================================================ Index: t/lib/TestAPRlib/finfo.pm =================================================================== --- t/lib/TestAPRlib/finfo.pm (revision 169037) +++ t/lib/TestAPRlib/finfo.pm (working copy) @@ -35,7 +35,8 @@ # Time season as the current time to workaround a bug in Win32's stat() # which APR::Finfo allows for, otherwise the two disagree. if (WIN32) { - utime undef, undef, $file; + my $now = time; + utime $now, $now, $file; } my $pool = APR::Pool->new(); ===================================================== perldoc -f utime says the two are equivalent, and I've verified that the finfo tests pass on 5.8.0 with it. -- best regards, randy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org