perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject additional APR::Status::is_* functions?
Date Sat, 07 May 2005 15:54:15 GMT
In the t/protocol/ tests, there's some comparisions of $@ to
APR::Const::ECONNABORTED and APR::Const::EOF made. As such,
it may be an idea to add and use
APR::Status::is_ECONNABORTED and APR::Status::is_EOF
instead. At the present time APR_EOF doesn't have any
variants:
  #define APR_STATUS_IS_EOF(s) ((s) == APR_EOF)
But for consistency with the other uses of APR::Status,
would it be an idea to add this anyway? This would
also handle possible changes to APR_STATUS_IS_EOF(s)
in the future.

In the same vein, there are variants in the
APR_STATUS_IS_SUCCESS(s) macro. This hasn't been a
problem yet, but should we add an APR::Status::is_SUCCESS
to be used in place of comparison to APR::SUCCESS?

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message