perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carl Brewer <c...@bl.echidna.id.au>
Subject Re: [mp2] 2.0.0 ok on NetBSD 2.0.2(i386)
Date Wed, 25 May 2005 23:23:09 GMT
Stas Bekman wrote:

> Actually, it is a problem of ModPerl::TestReport, my apologies for 
> discarding it in first place. I've committed the following fix to svn. 
> Please confirm that it works for you. Thanks.

I'll give this a try when I get a chance, am moving house at the moment :(


> 
> Index: Changes
> ===================================================================
> --- Changes     (revision 178490)
> +++ Changes     (working copy)
> @@ -12,6 +12,11 @@
> 
>  =item 2.0.1-dev
> 
> +fix ModPerl::TestReport used by t/REPORT and mp2bug to use
> +ExtUtils::MakeMaker's MM->parse_version to get the interesting
> +packages version number, w/o trying to load them (which may fail if
> +the environment is not right) [Stas]
> +
>  fix a bug in ModPerl::RegistryCooker: now stripping __(END|DATA)__
>  only at the beginning of the line [Stas]
> 
> 
> Index: lib/ModPerl/TestReport.pm
> ===================================================================
> --- lib/ModPerl/TestReport.pm   (revision 178501)
> +++ lib/ModPerl/TestReport.pm   (working copy)
> @@ -19,6 +19,8 @@
> 
>  use base qw(Apache::TestReportPerl);
> 
> +use ExtUtils::MakeMaker ();
> +
>  my @interesting_packages = qw(
>      CGI
>      ExtUtils::MakeMaker
> @@ -52,11 +54,7 @@
>          for my $dir (@inc) {
>              my $path = "$dir/$filename";
>              if (-e $path) {
> -                no warnings 'redefine';
> -                my $ver = eval { require $path;
> -                                 delete $INC{$path};
> -                                 $package->VERSION;
> -                         };
> +                my $ver = MM->parse_version($path);
>                  # two versions could be installed (one under Apache2/)
>                  push @{ $packages{$package} }, $ver if $ver;
>              }
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message