perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: utime on Win32
Date Sat, 21 May 2005 21:25:00 GMT
Randy Kobes wrote:
> In t/lib/TestAPR/finfo.pm, for Win32,
>    utime undef, undef, $file;
> is used. However, with perl-5.8.0, this leads to a warning
> about an uninitialized value being used, causing the finfo
> tests to fail. This apparently is a bug in 5.8.0, as it's OK
> with 5.8.6. Would the following patch be OK?
> ================================================
> Index: t/lib/TestAPRlib/finfo.pm
> ===================================================================
> --- t/lib/TestAPRlib/finfo.pm	(revision 169037)
> +++ t/lib/TestAPRlib/finfo.pm	(working copy)
> @@ -35,7 +35,8 @@
>      # Time season as the current time to workaround a bug in Win32's stat()
>      # which APR::Finfo allows for, otherwise the two disagree.
>      if (WIN32) {
> -        utime undef, undef, $file;
> +        my $now = time;
> +        utime $now, $now, $file;
>      }
> 
>      my $pool = APR::Pool->new();
> =====================================================
> perldoc -f utime says the two are equivalent, and I've
> verified that the finfo tests pass on 5.8.0 with it.
> 

+1, but add this note to the test so in the future someone won't try to 
"fix" it.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message