perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: Some small fixes...
Date Wed, 11 May 2005 04:37:21 GMT
Nick *** wrote:
>>>btw, any reason why you didn't use perl's link() and File::Copy to do the 
>>>work? calling external shell is not a very clean way to code when you have 
>>>an API to do that. 
> 
> 
>>Perl's link() on Cygwin seems to copy mod_perl.a to libmod_perl.a, but at this stage
mod_perl.a is still a dummy lib and at the end we get nothing. 
>>`ln -s` seems to create something like the shortcut on windows and it works.

I've added this explanation so in the future we won't try to "fix" it.

> And for File::Copy
> 
> Index: lib/Apache2/Build.pm
> ===================================================================
> --- lib/Apache2/Build.pm	(revision 169434)
> +++ lib/Apache2/Build.pm	(working copy)
> @@ -1587,7 +1587,7 @@
>      my $src = catfile $modperl_path, "$self->{MP_LIBNAME}.a";
>      my $dst = catfile $modperl_path, "lib$self->{MP_LIBNAME}.a";
>      qx{ln -s $src $dst} unless -e $dst;
> -    qx{cp $dyna_filepath $modperl_path/libDynaLoader.a};
> +    File::Copy::copy($dyna_filepath, "$modperl_path/libDynaLoader.a");
>  
>      $modperl_static_libs_cygwin = join ' ',
>          "-L$modperl_path",
> 
> 
> (I forgot to include it in the previous mail)

Thanks, committed.

> I didn't use File::Copy, because it's not use(d) at the beginning of Build.pm, so I thought
it isn't loaded.

It should be loaded. I've added the loading.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message