perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [mp2] problems with mod_perl2.pm fooling around with mod_perl.pm in %INC
Date Tue, 10 May 2005 05:06:48 GMT
Philip M. Golllucci wrote:
> Stas Bekman wrote:
> 
>> Anybody can tell me why the following code was added?
>>
>> % cat lib/mod_perl2.pm
>> [...]
>> # this stuff is here to assist back compat
>> # basically, if you
>> #  PerlModule mod_perl2
>> # or take similar steps to load mod_perl2 at
>> # startup you are protected against loading mod_perl.pm
>> # (either 1.0 or 1.99) at a later time by accident.
>> $mod_perl::VERSION = $mod_perl2::VERSION;
>> $INC{"mod_perl.pm"} = __FILE__;
>>
>> This breaks any detection mechanism, e.g. it broke libapreq1:
>> http://marc.theaimsgroup.com/?l=apache-modperl&m=111569421220736&w=2
>>
>> Any chance this can be removed?
>>
> Hi all,
> 
> Stas, I actually wanted to change that to
> $INC{mod_perl2.pm} = __FILE__

but won't that already be set, since this file was already required?

> Both you and Geoff caught me and said no, that this was there and 
> correct to prevent accidental loading of mp1 by later doing
> 'use mod_perl' If you had mp1 and mp2 in the same perl tree.  You then 
> suggested that based on Geoff's response to me
> that the comment above that be added.  Its about 1-2 months ago in the 
> archives of -dev

Do you have a URL to this discussion?

> My originall reason for chaning it was the output of Apache2::Status 
> which listed mod_perl.pm as version 1.999.xx which confused the hell out 
> of me because I thought it was going to be 1.29 or whatever mp1 is at 
> right now havn't looked in a while.

As it breaks code, it's probably not the right thing to do.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message