perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick *** <doink...@abv.bg>
Subject Fix warning and mod_perl.so build on Win32 and MP_STATIC_EXTS=1
Date Fri, 29 Apr 2005 10:22:51 GMT
Index: lib/Apache2/Build.pm
===================================================================
--- lib/Apache2/Build.pm	(revision 165278)
+++ lib/Apache2/Build.pm	(working copy)
@@ -785,7 +785,7 @@
 
     $bpm_mtime = (stat $INC{$bpm})[9] if $INC{$bpm};
 
-    if (-e "lib/$bpm" and (stat _)[9] > $bpm_mtime) {
+    if (-e "lib/$bpm" and $bpm_mtime and (stat _)[9] > $bpm_mtime) {
         #reload if Makefile.PL has regenerated
         unshift @INC, 'lib';
         delete $INC{$bpm};
@@ -1505,7 +1505,7 @@
     return $self->dynamic_link_header_default .
         "\t$defs" .
         ($symbols ? ' \\' . "\n\t-pdb:$symbols" : '') .
-        ' -out:$@';
+        ' -out:$@' . " \n\n";
 }
 
 sub dynamic_link_aix {


Please take a look at the "warning fix".
I'm not sure whether it's right, because $INC{$bpm} is set, but the value points to a wrong
file path.
That's why $bpm_mtime's value becomes undefined and we get a warning. Maybe we should reload
$bpm at this moment?

-----------------------------------------------------------------
http://host.GBG.bg - лидер в Уеб Хостинг решения и регистрация
на Домейн имена

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message