perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [mp2 patch] detection problems
Date Tue, 26 Apr 2005 18:07:29 GMT

> How about this patch:

looks great, with possibly one exception.

> 
> Index: Makefile.PL
> ===================================================================
> --- Makefile.PL (revision 164840)
> +++ Makefile.PL (working copy)
> @@ -9,7 +9,7 @@
>  use constant MIN_HTTPD_VERSION_DYNAMIC => '2.0.47';
>  use constant MIN_HTTPD_VERSION_STATIC  => '2.0.51';
> 
> -my($old_modperl_version, $old_modperl_pm);
> +my($old_modperl_version, $old_modperl_pm, $old_Apache2_pm);
> 
>  BEGIN {
>      eval {
> @@ -18,6 +18,7 @@
>          if ($mod_perl::VERSION < 1.999_22 && $old_mp2) {
>              $old_modperl_version = $mod_perl::VERSION;
>              $old_modperl_pm = delete $INC{'mod_perl.pm'};
> +            $old_Apache2_pm = delete $INC{'Apache2.pm'};

will this catch the case where someone nuked Apache2.pm but has mod_perl.pm
_not_ under Apache2/mod_perl.pm (as would happen with MP_APACHE2_INST=0) ?
I don't think it will, but I'm not sure - it's these things that made my
mind race :)

other than that, I like the new "problem files" format.  +1.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message