perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [PATCH] lib/mod_perl2.pm
Date Thu, 21 Apr 2005 13:52:05 GMT
Geoffrey Young wrote:
>>>Index: mod_perl2.pm
>>>===================================================================
>>>--- mod_perl2.pm        (revision 164006)
>>>+++ mod_perl2.pm        (working copy)
>>>@@ -41,7 +41,7 @@
>>> }
>>>
>>> $mod_perl::VERSION = $mod_perl2::VERSION;
>>>-$INC{"mod_perl.pm"} = __FILE__;
>>>+$INC{"mod_perl2.pm"} = __FILE__;
> 
> 
> the code as it stands is correct.  I believe the intent was a single
> 
>   PerlModule mod_perl2
> 
> would prevent later calls to
> 
>   use mod_perl;
> 
> from mucking things up during the transitional period.  we can, of course,
> revisit the logic behind that decision, but the patch you submitted doesn't
> make much sense - $INC{"mod_perl2.pm"} is properly set when mod_perl2 is use()d.

May I suggest that this exact comment above that line in mod_perl2.pm 
prevent the confusion and attempt to fix things?

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message