perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Damon Buckwalter <buck...@gmail.com>
Subject Re: ACL filesystem incompatibility and potential race condition
Date Fri, 04 Mar 2005 02:52:14 GMT
On Thu, 03 Mar 2005 21:12:21 -0500, Joe Schaefer
<joe+gmane@sunstarsys.com> wrote:
> Stas Bekman <stas@stason.org> writes:
> 
> > Joe Schaefer wrote:
> >> Cool;  I'm wondering why not just use fallback => 1 and remove the '=='
> >> overload?
> >
> > it doesn't seem to work. I did as you've suggested (to the current cvs):
> >
> >    'fallback' => 1,
> >
> > instead of:
> >
> >    '==' => \&num_cmp;
> >
> > and t/error/runtime.t now fails:
> 
> You have to remove "nomethod" also; all current tests pass for
> me with this patch:
> 
> Index: xs/APR/Error/Error_pm
> ===================================================================
> --- xs/APR/Error/Error_pm       (revision 156118)
> +++ xs/APR/Error/Error_pm       (working copy)
> @@ -4,10 +4,11 @@
>  use APR::Util ();
> 
>  use overload
> -    nomethod => \&fatal,
> +     fallback => 1,
> +#    nomethod => \&fatal,
>      'bool'   => \&str,
> -    '=='     => \&num_cmp,
> -    '!='     => \&num_cmp_not,
> +#    '=='     => \&num_cmp,
> +#    '!='     => \&num_cmp_not,
>      '0+'     => \&num,
>      '""'     => \&str;

This patch plus the previous one fom Stas works nicely for me versus
the SVN trunk version.  If you guys are in Portland, Oregon any time
soon, I owe you a beer. 8-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message