Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 93533 invoked from network); 17 Feb 2005 03:38:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 17 Feb 2005 03:38:12 -0000 Received: (qmail 70984 invoked by uid 500); 17 Feb 2005 03:38:10 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 70843 invoked by uid 500); 17 Feb 2005 03:38:09 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 70818 invoked by uid 99); 17 Feb 2005 03:38:09 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from mail.logilune.com (HELO mail.logilune.com) (195.80.154.36) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 16 Feb 2005 19:38:06 -0800 Received: from [127.0.0.1] (localhost.logilune.com [127.0.0.1]) by mail.logilune.com (Postfix) with ESMTP id EB1C31E1969; Thu, 17 Feb 2005 04:38:02 +0100 (CET) Message-ID: <42141199.206@stason.org> Date: Wed, 16 Feb 2005 22:38:01 -0500 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-us, en, he, ru MIME-Version: 1.0 To: Cory Omand Cc: mod_perl Dev , Frederic LE GUERN Subject: Re: [mp2] [PATCH] DESTDIR does not apply to mod_perl.so and includes References: <42082AD4.4060906@stason.org> <42082EF9.3000004@stason.org> <420A9D66.6060104@stason.org> <1108587134.26634.113.camel@haywire> <4213B8B2.6050106@stason.org> <1108597547.26634.267.camel@haywire> <4213E9B8.5030702@stason.org> <1108604717.26634.300.camel@haywire> In-Reply-To: <1108604717.26634.300.camel@haywire> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Cory Omand wrote: [...] >>That's better, Cory, but why introducing new variables? you still kept the >>old ones, but they aren't used anymore, are they? (e.g. AP_LIBEXECDIR) >>Looks like a lot of extra noise. >> >>May be keep the old makefile vars unchanged but merge the new prefix >>transparently into those vars if the prefix exists? or at least drop the >>not-used vars? > > > My initial thought was that this should behave like DESTDIR for > other packages -- it is only set on installation. Therefore, when > you are using AP_LIBEXECDIR, you know it is pointing to where things > will be when installed, but AP_LIBEXECDESTDIR is not referenced > anywhere in the compilation portions of the makefile. As I have > another look through the makefile, however, it appears that the > only purpose of the MODPERL_AP_* variables is for installation, so > maybe moving to use the existing variable names is fine... > > Another patch is attached -- Looks perfect to me, Cory (it will need a few tiny style tweaks, but don't worry about that). +1 once others vote on this it can go in. -- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org