perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [mp2] [PATCH] DESTDIR does not apply to mod_perl.so and includes
Date Thu, 17 Feb 2005 00:47:52 GMT
Cory Omand wrote:
> On Wed, 2005-02-16 at 13:18, Stas Bekman wrote:
> 
>>But doesn't it need to deal with the trailing slash? Is it ok if someone 
>>adds one and then it'll becomes foo//bar? I guess we also assume that the 
>>right part always has the leading slash, since it's a real path to the 
>>installed Apache dir, right? In the case of windows where it will become 
>>fooc:\bar is probably irrelevant here.
> 
> 
> Stas,
> 
> It shouldn't matter if someone specifies the trailing slash, as all
> that this path is used for is as an argument to $(MODPERL_CP).  You
> are correct about the right portion -- it always will have the
> leading slash, because that path comes back from apxs. I hadn't
> considered the windows case, however.  I've attached a new version
> of the patch which is 'volume aware', provides canonical paths, and
> would properly handle the case where apxs returns a path without a
> leading slash.

That's better, Cory, but why introducing new variables? you still kept the 
old ones, but they aren't used anymore, are they? (e.g. AP_LIBEXECDIR) 
Looks like a lot of extra noise.

May be keep the old makefile vars unchanged but merge the new prefix 
transparently into those vars if the prefix exists? or at least drop the 
not-used vars?


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message