perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Markus Wichitill <ma...@gmx.de>
Subject Re: [PATCH] Show Apache and Perl environment in Apache::Status 2.x
Date Sat, 15 Jan 2005 12:16:43 GMT
Philippe M. Chiasson wrote:
> Patch didn't apply cleanly for me against latest subversion. 

Odd, it's against current SVN and your MUA even supports format=flowed to 
unwrap that one wrapped line.

>> +    # show perl environment
> This isn't needed.

Well, I like simple comments like that for navigational purposes, but if you 
prefer to keep diff lines to an absolute minimum, feel free to change it.

>> -            qq{<b>Under the "modperl" handler, the environment is:</b>};
>> +            qq{<b>Under the "modperl" handler, the Perl %ENV is:</b>};
> Why change the wording ?

To be more specific, since there's more than one environment. Which happens 
to be somewhat confusing for Apache newbies BTW.

>> -            qq{<b>Under the "perl-script" handler, the environment 
>> is</b>:};
>> +            qq{<b>Under the "perl-script" handler, the Perl %ENV 
>> is:</b>};
> Same question.

Also, the order of "<b>" and ":" was inconsistent before (I can nitpick, too ;)

>> +    push @retval, qq{<b>The Apache subprocess_env is:</b>};
> '<b>$r->subprocess_env is :</b>'

I like to call it the "Apache environment" and not just "subprocess 
environment", because it's used for more than just subprocesses. And 
sometimes it's interesting just to see e.g. the SSL vars, without even 
involving $r/mod_perl.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message