perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [PATCH] Show Apache and Perl environment in Apache::Status 2.x
Date Sat, 15 Jan 2005 05:49:56 GMT
Patch didn't apply cleanly for me against latest subversion.

A few nitpicks about your patch follows:

Markus Wichitill wrote:

> Index: lib/Apache/Status.pm
> ===================================================================
> --- lib/Apache/Status.pm    (revision 125243)
> +++ lib/Apache/Status.pm    (working copy)
> @@ -345,12 +345,12 @@
>  sub status_env {
>      my ($r) = shift;
>
> +    # show perl environment
>      my @retval = ("<p>\n");
> -

This isn't needed.

>      if ($r->handler eq 'modperl') {
>          # the handler can be executed under the "modperl" handler
>          push @retval,
> -            qq{<b>Under the "modperl" handler, the environment is:</b>};
> +            qq{<b>Under the "modperl" handler, the Perl %ENV is:</b>};

Why change the wording ?

>          # XXX: I guess we could call $r->subprocess_env; and show how
>          # would it look like under the 'perl-script' environment, but
>          # under the 'modperl' handler %ENV doesn't get reset,
> @@ -359,13 +359,22 @@
>      } else {
>          # the handler can be executed under the "perl-script" handler
>          push @retval,
> -            qq{<b>Under the "perl-script" handler, the environment 
> is</b>:};
> +            qq{<b>Under the "perl-script" handler, the Perl %ENV 
> is:</b>};
>      }

Same question.

>      push @retval, "\n</p>\n";
>      push @retval, "<pre>",
>          (map "$_ = " . escape_html($ENV{$_}||'') . "\n",
>              sort keys %ENV), "</pre>";
>
> +    # show apache environment
> +    my $ap_env = $r->subprocess_env();
> +    push @retval, "\n<p>\n";
> +    push @retval, qq{<b>The Apache subprocess_env is:</b>};

'<b>$r->subprocess_env is :</b>'

> +    push @retval, "\n</p>\n";
> +    push @retval, "<pre>",
> +        (map "$_ = " . escape_html($ap_env->{$_}||'') . "\n",
> +            sort keys %$ap_env), "</pre>";
> +
>      \@retval;
>  }

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5


Mime
View raw message