perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [mp2 patch] lib/ModPerl/DummyVersions.pm
Date Thu, 13 Jan 2005 21:52:02 GMT
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> 
>>Stas Bekman wrote:
>>
>>>Randy Kobes wrote:
>>>
>>>>On Tue, 4 Jan 2005, Stas Bekman wrote:
>>>>
>>>> [...]
>>>>>the issues:
>>>>>
>>>>>1) I'm not sure APR modules should get their versions as
>>>>>2.0.0. Should it be 0.9 instead? since Apache 2.0 uses
>>>>>libapr 0.9.x.
>>>>
>>>>
>>>>+1: that seems to make sense.
>>
>>
>>-0: Like I said earlier, I am not sure how we can ensure we bump
>>these 0.9 versions on each new mp2 release.
> 
> 
> At the moment we don't know what's happening with APR interface, so may be 
> leaving it at 0.9 until we know is fine.

Having APR versions set to 0.009000 is causing problems with the CPAN indexer
since the previous versions were 0.01 :

      module: APR::PerlIO
     version: 0.009000
     in file: mod_perl-2.0.0-RC3/xs/APR/PerlIO/PerlIO.pm
      status: Not indexed because
              mod_perl-2.0.0-RC2-XMas/xs/APR/PerlIO/PerlIO.pm in
              G/GO/GOZER/mod_perl-2.0.0-RC2-XMas.tar.gz has a higher
              version number (0.01)

So unless someone can find a better solution, the straightforward fix would seem
to automatically assing $mod_perl::VERSION to APR::* modules as well.

Index: lib/ModPerl/WrapXS.pm
===================================================================
--- lib/ModPerl/WrapXS.pm	(revision 125085)
+++ lib/ModPerl/WrapXS.pm	(working copy)
@@ -367,8 +367,7 @@
  sub module_version {
      local $_ = shift;
      require mod_perl;
-    # XXX: for now APR gets its libapr-0.9 version
-    return /^APR/ ? "0.009000" : "$mod_perl::VERSION";
+    return "$mod_perl::VERSION";
  }

  sub write_makefilepl {

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message