perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Cholet <cho...@logilune.com>
Subject Re: t/perl/signals failure
Date Wed, 05 Jan 2005 23:39:11 GMT
Le 5 janv. 05, à 18:54, Stas Bekman a écrit :

>>> That probably means that Apache installs its own sighandler or 
>>> something like that? It certainly shows that a user can't use perl's 
>>> ALRM on MaxOSX.
>>>
>>> Please post a skip patch?
>> Sure, but maybe this is also dependent on the version of Perl I'm 
>> running,
>> MacOSX stock (5.8.1-RC3)
>> I'll try to find some time to install a recent Perl to test with.
>
> we don't like RCs, since we can't test for those. Any chance to test 
> with non-RC?

It fails in the same way with MAINT.

>
>> Index: t/response/TestPerl/signals.pm
>> ===================================================================
>> --- t/response/TestPerl/signals.pm      (revision 124104)
>> +++ t/response/TestPerl/signals.pm      (working copy)
>> @@ -32,6 +32,10 @@
>>      # doesn't work under static prefork
>>      if (!$static) {
>> +      if ($^O eq 'darwin') {
>> +        skip "ALRM can't be used on darwin", 1;
>
> I believe that should be s|1|0|;
>
>> +      }
>> +      else {
>>          local $ENV{PERL_SIGNALS} = "unsafe";
>>          eval {
>> @@ -41,6 +45,7 @@
>>              alarm 0;
>>          };
>>          ok t_cmp $@, qr/alarm/, "SIGALRM / unsafe %SIG";
>> +      }
>>      }
>>      # POSIX::sigaction doesn't work under 5.6.x
>
> +1, you have the commit access, right?

yes.

> (the identation is wrong in the original, i'll fix it later).

I believe I messed it up even further with this patch.
I'll go read the coding style guide now.

--
Eric Cholet


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message