Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <41C06003.6040602@stason.org>
Date: Wed, 15 Dec 2004 11:02:11 -0500
From: Stas Bekman <stas@stason.org>
Organization: Hope, Humanized
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913
MIME-Version: 1.0
To: Steve Hay <steve.hay@uk.radan.com>
Cc: mod_perl Dev <dev@perl.apache.org>
Subject: Re: t/perl/ithreads.t revisited
References: <41A63198.6090503@stason.org> <41A7738E.3030801@stason.org>
 <41AEBFB6.3060300@ectoplasm.org> <41B48CA3.7020509@uk.radan.com>
 <41B49E18.6000308@uk.radan.com> <41B7845B.2090405@stason.org>
 <41B82D26.2040802@uk.radan.com> <41B912E4.6040107@stason.org>
 <41B9B7BA.9020107@uk.radan.com> <41B9BE32.2070900@stason.org>
 <41B9CF36.3060403@uk.radan.com> <41B9DAEE.80802@stason.org>
 <41B9E77E.1070507@uk.radan.com> <41B9EAB7.4030002@stason.org>
 <41BD8C8F.1040509@uk.radan.com> <41BDB22A.2000901@stason.org>
 <41BDD0EF.5060701@uk.radan.com> <41BDD6B1.9010305@stason.org>
 <41BDD808.6020800@uk.radan.com> <41BDD896.1010305@stason.org>
 <41BDDA4D.9020700@uk.radan.com> <41BDDD2D.5010103@stason.org>
 <41BEACDC.6050801@uk.radan.com> <41BEF73C.6020504@stason.org>
 <41BEFD07.9090600@uk.radan.com> <41BEFFB0.6000106@stason.org>
 <41BF02B3.1060209@uk.radan.com> <41BF072D.80107@stason.org>
 <41BF1115.6000905@uk.radan.com> <41BFBC41.10806@stason.org>
 <41BFFEE0.4060509@uk.radan.com>
In-Reply-To: <41BFFEE0.4060509@uk.radan.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Steve Hay wrote:
> Stas Bekman wrote:
> 
> 
>>Steve Hay wrote:
>>[...]
>> 
>>
>>
>>>>>The error_log only contains:
>>>>>
>>>>>[Tue Dec 14 15:06:47 2004] [notice] Child 3844: Child process is running
>>>>>[Tue Dec 14 15:06:47 2004] [notice] Child 3844: Acquired the start mutex.
>>>>>[Tue Dec 14 15:06:47 2004] [notice] Child 3844: Starting 50 worker threads.
>>>>>[Tue Dec 14 15:06:47 2004] [debug] child.c(684): Child 3844: Worker 
>>>>>thread 0 starting.
>>>>>
>>>>>(and another 49 message like the last one, since ThreadsPerChild is 50)
>>>>> 
>>>>>
>>>>>       
>>>>>
>>>>
>>>>BTW, do we still need this hack? I thought it was supposed to be fixed in 
>>>>2.0.50, no? (talking about the need to run as many threads as vhosts)
>>>>
>>>>     
>>>>
>>>
>>>You're correct in that it is fixed in 2.0.50 (I just tried the test 
>>>suite with ThreadsPerChild set at 2 and it worked OK still), but it was 
>>>agreed at the time to leave the higher value in place for backwards 
>>>compatibility.  See:
>>>
>>>http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=108505772101330&w=2
>>>   
>>>
>>
>>Right, but A-T knows the apache version, so it could do the appropriate 
>>decision when writing that file. I'm sure you'd appreciate to not see so 
>>many useless logs in error_log and also it'll be faster, since many less 
>>threads will be started, no?
>>
>>Is it possible that you could write that patch? That would be:
>>Apache-Test/lib/Apache/TestConfig.pm
>>
>>In fact I think it'd be cool to fix TestConfig.pm not to write irrelevant 
>>config sections (e.g. prefork for win32, and vice versa).
>>
>> 
>>
>>
>>>Having said that, that mail suggested adding a  BACK_COMPAT_MARKER 
>>>comment, which I don't see.
>>>   
>>>
>>
>>Assuming that you work on that patch, you could definitely add it in the 
>>right place.
>>
> 
> I'm only around today, Thurs & Fri, then I'm off till January.  It's 
> unlikely I'll be able to look in these next three days, but I may get a 
> chance over the holiday...
> 
> I'd certainly like to have fewer threads started and less clutter in the 
> conf file, so it is worth doing.

OK, I'll "todo" this and if no one beats you to it, you could do it in 
January. ;0) Thanks Steve

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org