Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (hermes.apache.org: domain of gozer@ectoplasm.org
 designates 66.34.202.202 as permitted sender)
Message-ID: <41BA3DE8.7080603@ectoplasm.org>
Date: Fri, 10 Dec 2004 16:23:04 -0800
From: "Philippe M. Chiasson" <gozer@ectoplasm.org>
User-Agent: Mozilla Thunderbird 0.9 (X11/20041127)
MIME-Version: 1.0
To: Stas Bekman <stas@stason.org>
Cc: mod_perl Dev <dev@perl.apache.org>
Subject: Re: [PATCH] ModPerl::Util::piid()
References: <41BA2ABD.6050705@stason.org>
In-Reply-To: <41BA2ABD.6050705@stason.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig712D95BF54C1CA4D6C6B3EF4"

--------------enig712D95BF54C1CA4D6C6B3EF4
Content-Type: multipart/mixed;
 boundary="------------090505050407040201020608"

This is a multi-part message in MIME format.
--------------090505050407040201020608
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Stas Bekman wrote:
> While debugging the current post_config problem I wanted to know which 
> perl interpreter is currently running, so I've added the following 
> wrapper, that under ithreads perl returns the address of my_perl (aTHX) 
> (.e.g 0x92ac760) and 0 under non-threaded perl (0x0). I tend to want to 
> add it to our API (we already have the function that returns the thread 
> id: APR::OS::current_thread_id();).
> 
> 1) do we want it?

If it's a potentially usefull piece of debugging information, I think I'd
want it too.
 
> 2) is it a good name? I typed ppid quite a few times instead of piid 
> while writing this patch :( ppid stands for Perl Interpreter ID'. So if 
> you think it should have a different please have a say. e.g. 
> current_perl_id() or current_perl_interpreter_id (but it's not really an 
> id, but just an address)

ModPerl::Util::this_perl_id() ?
ModPerl::Util::this_perl() ?

> [...]

Otherwise, the patch looks good to me.

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

--------------090505050407040201020608
Content-Type: text/x-vcard; charset=utf-8;
 name="gozer.vcf"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="gozer.vcf"

begin:vcard
fn:Philippe M. Chiasson
n:Chiasson;Philippe M.
email;internet:gozer@ectoplasm.org
x-mozilla-html:FALSE
version:2.1
end:vcard


--------------090505050407040201020608--

--------------enig712D95BF54C1CA4D6C6B3EF4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBuj3tyzKhB4jDpaURAoCqAJ9PTsu5gVA14Br0BJy9nWECTtfT5gCdEUlt
kxGkDPuFV5ilPCC48JN6lq0=
=Evya
-----END PGP SIGNATURE-----

--------------enig712D95BF54C1CA4D6C6B3EF4--