Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (hermes.apache.org: domain of gozer@ectoplasm.org
 designates 66.34.202.202 as permitted sender)
Message-ID: <41AEBFB6.3060300@ectoplasm.org>
Date: Wed, 01 Dec 2004 23:09:42 -0800
From: "Philippe M. Chiasson" <gozer@ectoplasm.org>
User-Agent: Mozilla Thunderbird 0.9 (X11/20041103)
MIME-Version: 1.0
To: Stas Bekman <stas@stason.org>
Cc: Steve Hay <steve.hay@uk.radan.com>,
	mod_perl Dev <dev@perl.apache.org>,
	Randy Kobes <randy@theoryx5.uwinnipeg.ca>
Subject: Re: t/perl/ithreads.t revisited
References: <41A63198.6090503@stason.org> <41A75AB8.7040304@uk.radan.com>
 <41A7726D.2060302@uk.radan.com> <41A7738E.3030801@stason.org>
In-Reply-To: <41A7738E.3030801@stason.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigDEB0DF4116342AD08ED64AD8"

--------------enigDEB0DF4116342AD08ED64AD8
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Stas Bekman wrote:
> Steve Hay wrote:
> 
>>>> Next I want you to try cutting off things from startup files and 
>>>> httpd.conf, to find whether it's some unrelated module that is 
>>>> loaded that causes the problem. I suspect that because the sister 
>>>> test t/perl/ithreads2.t doesn't fail, and it runs exactly the same 
>>>> code, but inside a dedicated interpreter pool, which doesn't load 
>>>> any other modules.
>>>
>>> Will try (again), but I've tried this before and got nowhere with it :(
>>>
>> While trawling through the httpd.conf file I found a couple of what 
>> look like errors:  Two places say "PERL_ITHREADS" instead of 
>> "PERL_USEITHREADS".  Correcting these apparent mistakes fixes the 
>> broken test sequence previously reported!
> 
> [...]
> 
>> After making this change I found that reload.t now fails test 2.  This 
>> patch (against current CVS, since I can't get SVN working) fixes that:
>>
>> Index: t/modules/reload.t
>> ===================================================================
>> RCS file: /home/cvspublic/modperl-2.0/t/modules/reload.t,v
>> retrieving revision 1.4
>> diff -u -u -r1.4 reload.t
>> --- t/modules/reload.t  11 Sep 2004 01:02:28 -0000      1.4
>> +++ t/modules/reload.t  26 Nov 2004 18:05:21 -0000
>> @@ -53,7 +53,7 @@
>>  touch_mtime($test_file);
>>
>>  {
>> -    my $expected = join '', map { "$_:" . uc($_) . "\n" } sort @tests;
>> +    my $expected = join '', map { "$_:$_\n" } sort @tests;
>>      my $received = get_body($same_interp, \&GET, $location);
>>      $skip++ unless defined $received;
>>      skip_not_same_interp(
> 

That's not a correct fix to the problem. reload.t is apparently now failing for
you, and this patch just ignores the failure. 

Can you try t/modules/reload.t with your ITHREAD patch but add:
 PerlSetVar ReloadDebug On
to your httpd.conf and see what happens.

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

--------------enigDEB0DF4116342AD08ED64AD8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBrr+2yzKhB4jDpaURAsNVAJ0XUtgJXx8NXM5LjMsGVO7JJHKg+gCfSLfR
TRULiGBl/xlkqYOwbpb/8uQ=
=3rJ2
-----END PGP SIGNATURE-----

--------------enigDEB0DF4116342AD08ED64AD8--