perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [Patch mp2] PerlConfigRequire && PerlPostConfigRequire
Date Thu, 16 Dec 2004 19:03:11 GMT
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> 
>>Here is a new version of my original patch that includes tests (no doc 
>>though)
> 
>>+    merge_item(PerlPostConfigRequire);
> 
> I was wondering if it makes sense to merge this one.

It's necessary, for the same reason PerlRequire or PerlModule
has to be merged. Otherwise, the vhost config for PerlPostConfigRequire
will get lost in the merge. (You'll notice my original patch wasn't merging
and wasn't working as a side effect)

>>+    
> 
> Philippe, mind you not add lines like: /^    $/, I have to cleanup those 
> after every of your commits :( Any chance your editor can be configured 
> not to add those space padding?

Yes, sorry 'bout that. I've figured out how to avoid this hapenning with
my favorite (unnamed) editor ;-).

BTW, I noticed that there are a lot of these kind of /^    $/ in src/modules/perl/*.c
as of today. If you want, I'll go thru them and make a whitespace cleanup patch later
on today.

>>Index: t/htdocs/vhost/post_config.pl
>>===================================================================
>>--- t/htdocs/vhost/post_config.pl	(revision 0)
>>+++ t/htdocs/vhost/post_config.pl	(revision 0)
>>@@ -0,0 +1,9 @@
>>+use warnings;
>>+use strict;
> 
> 
> should be:
> 
> use strict;
> use warnings FATAL => 'all';

Yes

>>Index: t/response/TestVhost/config.pm
>>===================================================================
>>--- t/response/TestVhost/config.pm	(revision 112024)
>>+++ t/response/TestVhost/config.pm	(working copy)
>>@@ -17,19 +17,25 @@
>> 
>> use Apache::Const -compile => 'OK';
>> 
>>+our $Restart_Count;
> 
> anything wrong with $restart_count? and I'd add a comment:
> 
> # initialized in t/htdocs/vhost/post_config.pl

Good thoughs. Patch attached.


--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message