perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [Patch mp2] PerlConfigRequire && PerlPostConfigRequire
Date Thu, 16 Dec 2004 16:56:58 GMT
Philippe M. Chiasson wrote:
> Here is a new version of my original patch that includes tests (no doc 
> though)

> +    merge_item(PerlPostConfigRequire);

I was wondering if it makes sense to merge this one.

> +    

Philippe, mind you not add lines like: /^    $/, I have to cleanup those 
after every of your commits :( Any chance your editor can be configured 
not to add those space padding?

> Index: t/htdocs/vhost/post_config.pl
> ===================================================================
> --- t/htdocs/vhost/post_config.pl	(revision 0)
> +++ t/htdocs/vhost/post_config.pl	(revision 0)
> @@ -0,0 +1,9 @@
> +use warnings;
> +use strict;

should be:

use strict;
use warnings FATAL => 'all';

> Index: t/response/TestVhost/config.pm
> ===================================================================
> --- t/response/TestVhost/config.pm	(revision 112024)
> +++ t/response/TestVhost/config.pm	(working copy)
> @@ -17,19 +17,25 @@
>  
>  use Apache::Const -compile => 'OK';
>  
> +our $Restart_Count;

anything wrong with $restart_count? and I'd add a comment:

# initialized in t/htdocs/vhost/post_config.pl

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message