perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject [mp2] callback returning bogus error code don't log the error
Date Fri, 10 Dec 2004 02:07:43 GMT
Found a new problem. If the callback returns a bogus error code, no
error is logged, but 500 is sent.

For example:

Index: t/hooks/TestHooks/push_handlers.pm
===================================================================
--- t/hooks/TestHooks/push_handlers.pm  (revision 111452)
+++ t/hooks/TestHooks/push_handlers.pm  (working copy)
@@ -38,7 +38,7 @@
  }

  sub end { return Apache::DONE }
-sub say { shift->print(shift,"\n"); return Apache::DECLINED }
+sub say { shift->print(shift,"\n"); 12345  }

  sub conf {
      # this one is configured from httpd.conf

just sends 500 to the client, nothing in the logs.

This brings us to a more painful problem. the code in startup.pl:

   $s->push_handlers(PerlPostConfigHandler => sub { 12345 });

won't let the server start, and no error is logged, the server just
quits.

---------------

probably unrelated, but when tracing this test I got:

modperl_handler_resolve: [8896/1107602352 rabbit.stason.org:8529] handler 
TestHooks::push_handlers::conf was not compiled at startup, attempting to 
resolve using current pool 0x9f71a40

modperl_callback_run_handlers: TestHooks::push_handlers::conf returned 12345

modperl_callback_run_handlers: error status 12345 leaves 1078468780 
uncalled handlers

"1078468780 uncalled handlers" - wow, that's a lot :)

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message