perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [mp2 Patch] Static build and mod_perl include files
Date Tue, 07 Dec 2004 22:50:41 GMT
Philippe M. Chiasson wrote:

> Index: Makefile.PL

> -        MODPERL_AP_INCLUDEDIR  => $build->ap_includedir(),
> +        MODPERL_AP_INCLUDEDIR  => $build->->install_headers_dir(),

doesn't look like you've tested it :) ->->

>          MODPERL_XS_H_FILES => join(" \\\n\t", @xs_h_files),
>      },
>      clean     => {
> Index: lib/Apache/Build.pm
> ===================================================================
[...]
> +    
> +    print $fh $self->canon_make_attr('AP_INCLUDEDIR', 
> +                                     $self->install_headers_dir());
>  
> -    for my $q (qw(LIBEXECDIR INCLUDEDIR)) {
> +    for my $q (qw(LIBEXECDIR)) {
>          print $fh $self->canon_make_attr("AP_$q",
>                                           $self->apxs(-q => $q));
>      }

no more need for for() loop here :)

otherwise +1.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message