perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [mp2 Patch] Static build and mod_perl include files
Date Tue, 07 Dec 2004 22:50:12 GMT
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> 
>>Stas Bekman wrote:
>>
>>>Philippe M. Chiasson wrote:
>>>
>>>>Stas just discovered that when building static, mod_perl's header 
>>>>files ended up
>>>>being installed in httpd's build tree. That had 2 bad effects. First, 
>>>>3rd party
>>>>modules wouldn't find the headers. Second, thus polluted, the httpd 
>>>>source tree
>>>>wouldn't build anymore, confused by header files that shouldn't be 
>>>>there.
>>>>
>>>>The following patch _fixes_ that problem, but the only way I could 
>>>>manage to do
>>>>it was by peeking at config_vars.mk. It did make me think about how 
>>>>we could make
>>>>use of config_vars.mk ourselves more directly and not rely on 
>>>>system(apxs) as much
>>>>in the future.
>>>>
>>>>Anyways, here is the patch itself.
>>>
>>> [...]
> 
> OK, how about then writing a wrapper for install_headers_dir() which will 
> do the right thing internally. Exposing this logic/complexity at the 
> Makefile.PL level doesn't sound as a very good idea.

You are right, would be much cleaner to do so. Patch attached !

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message