perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: win32 bb->cleanup crashes are still there?
Date Tue, 07 Dec 2004 18:23:19 GMT
Randy, please try this patch:

Index: xs/maps/apr_functions.map
===================================================================
--- xs/maps/apr_functions.map	(revision 110129)
+++ xs/maps/apr_functions.map	(working copy)
@@ -94,7 +94,8 @@
  !apr_brigade_write
  !apr_brigade_puts
  -apr_brigade_putc
- apr_brigade_cleanup
+~ apr_brigade_cleanup
+ mpxs_APR__Brigade_cleanup
  ~apr_brigade_flatten
  ~apr_brigade_pflatten
  ?apr_brigade_split_line
Index: xs/APR/Brigade/APR__Brigade.h
===================================================================
--- xs/APR/Brigade/APR__Brigade.h	(revision 110129)
+++ xs/APR/Brigade/APR__Brigade.h	(working copy)
@@ -14,6 +14,14 @@
   */

  static MP_INLINE
+void mpxs_APR__Brigade_cleanup(apr_bucket_brigade *brigade)
+{
+    /* apr has a broken prototype (passing 'void *' instead of
+     * 'apr_bucket_brigade *', so use a wrapper here */
+    apr_brigade_cleanup(brigade);
+}
+
+static MP_INLINE
  apr_bucket_brigade *mpxs_apr_brigade_create(pTHX_ SV *CLASS,
                                              apr_pool_t *p,
                                              apr_bucket_alloc_t *ba)
Index: xs/tables/current/ModPerl/FunctionTable.pm
===================================================================
--- xs/tables/current/ModPerl/FunctionTable.pm	(revision 110129)
+++ xs/tables/current/ModPerl/FunctionTable.pm	(working copy)
@@ -2,7 +2,7 @@

  # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
  # ! WARNING: generated by ModPerl::ParseSource/0.01
-# !          Mon Dec  6 09:38:51 2004
+# !          Tue Dec  7 13:02:32 2004
  # !          do NOT edit, any changes will be lost !
  # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@@ -5284,6 +5284,16 @@
    },
    {
      'return_type' => 'void',
+    'name' => 'mpxs_APR__Brigade_cleanup',
+    'args' => [
+      {
+        'type' => 'apr_bucket_brigade *',
+        'name' => 'brigade'
+      }
+    ]
+  },
+  {
+    'return_type' => 'void',
      'name' => 'mpxs_APR__Brigade_concat',
      'args' => [
        {


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message