perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: win32 bb->cleanup crashes are still there?
Date Tue, 07 Dec 2004 16:54:18 GMT
Joe Schaefer wrote:
> Stas Bekman <stas@stason.org> writes:
> 
> [...]
> 
> 
>>Hmm, the apr part does look wrong:
>>
>>APU_DECLARE(apr_status_t) apr_brigade_cleanup(void *data)
>>{
>>     apr_bucket_brigade *b = data;
>>     apr_bucket *e;
>>
>>shouldn't it be:
>>
>>     apr_bucket_brigade *b = (apr_bucket_brigade *)data;
> 
> 
> In C, this cast makes no difference at all; and lots
> of C programmers would advise against it.  The likely
> reason they use a (void *) argument in apr_brigade_cleanup
> instead of an (apr_bucket_brigade *) is because that
> function is also registered as a pool cleanup.  I'm 
> actually more suspicious of the APU_DECLARE vs 
> APU_DECLARE_NONSTD part, because its possible (haven't
> checked tho) that Win32's calling coventions are different
> for the pool cleanup invocation verses a direct dll 
> invocation.
> 
> See if you can get wrowe's attention; he'll definitely
> know if I'm barking up the wrong tree or not.

Thanks Joe. I've posted a qestion to apr-dev. Seems like it's indeed 
not-so-correct as Joe has replied.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message