perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: win32 bb->cleanup crashes are still there?
Date Tue, 07 Dec 2004 16:15:59 GMT
Randy Kobes wrote:
[...]
> However, I tried changing WrapXS/APR/Brigade/Brigade.xs
> to read (in the declaration of apr_brigade_cleanup)
> 
> apr_status_t
> apr_brigade_cleanup(data)
>     APR::Brigade data
> 
> With this, the above patched protocol/echo_bbs2 tests all
> pass. 

Excellent. Sounds very logical to me.

> Given the declaration of apr_brigade_cleanup(void *data) in
> $APACHE2/include/apr_buckets.h, this change seems wrong -
> perhaps it indicates something's wrong in Win32?

Hmm, the apr part does look wrong:

APU_DECLARE(apr_status_t) apr_brigade_cleanup(void *data)
{
     apr_bucket_brigade *b = data;
     apr_bucket *e;

shouldn't it be:

     apr_bucket_brigade *b = (apr_bucket_brigade *)data;

? let me run this through apr-dev.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message