perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: t/perl/ithreads.t revisited
Date Thu, 02 Dec 2004 07:09:42 GMT
Stas Bekman wrote:
> Steve Hay wrote:
> 
>>>> Next I want you to try cutting off things from startup files and 
>>>> httpd.conf, to find whether it's some unrelated module that is 
>>>> loaded that causes the problem. I suspect that because the sister 
>>>> test t/perl/ithreads2.t doesn't fail, and it runs exactly the same 
>>>> code, but inside a dedicated interpreter pool, which doesn't load 
>>>> any other modules.
>>>
>>> Will try (again), but I've tried this before and got nowhere with it :(
>>>
>> While trawling through the httpd.conf file I found a couple of what 
>> look like errors:  Two places say "PERL_ITHREADS" instead of 
>> "PERL_USEITHREADS".  Correcting these apparent mistakes fixes the 
>> broken test sequence previously reported!
> 
> [...]
> 
>> After making this change I found that reload.t now fails test 2.  This 
>> patch (against current CVS, since I can't get SVN working) fixes that:
>>
>> Index: t/modules/reload.t
>> ===================================================================
>> RCS file: /home/cvspublic/modperl-2.0/t/modules/reload.t,v
>> retrieving revision 1.4
>> diff -u -u -r1.4 reload.t
>> --- t/modules/reload.t  11 Sep 2004 01:02:28 -0000      1.4
>> +++ t/modules/reload.t  26 Nov 2004 18:05:21 -0000
>> @@ -53,7 +53,7 @@
>>  touch_mtime($test_file);
>>
>>  {
>> -    my $expected = join '', map { "$_:" . uc($_) . "\n" } sort @tests;
>> +    my $expected = join '', map { "$_:$_\n" } sort @tests;
>>      my $received = get_body($same_interp, \&GET, $location);
>>      $skip++ unless defined $received;
>>      skip_not_same_interp(
> 

That's not a correct fix to the problem. reload.t is apparently now failing for
you, and this patch just ignores the failure. 

Can you try t/modules/reload.t with your ITHREAD patch but add:
 PerlSetVar ReloadDebug On
to your httpd.conf and see what happens.

--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

Mime
View raw message