perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1
Date Sun, 21 Nov 2004 16:54:17 GMT
Markus Wichitill wrote:
> Stas Bekman wrote:
> 
>> Randy Kobes wrote:
>>
>>> For the protocol/echo_nonblock.t test, as I mentioned,
>>> the failure of the last test (which is expected to timeout)
>>> only occurred when running the full test suite. I'll
>>> try to narrow it down - one combination that does fail is
>>>    perl t/TEST -v apr protocol
>>> in which test 3 in protocol/echo_nonblock receives
>>> "should timeout", rather than "TIMEUP".
>>>
>>> For both of these tests, nothing was in the error log
>>> that could offer a clue.
>>
>>
>> OK, looking forward to the SMOKE's shortest sequence.
> 
> 
> I'm seeing this issue, too, now, after having built from SVN the first 
> time (probably just coincidence, since I haven't built often during the 
> last few weeks). It's not always failing, but it's also failing if the 
> test is run on its own:
> 
> C:\Dev\src\modperl2>perl t\TEST -v t\protocol\echo_nonblock.t
> [...]
> t\protocol\echo_nonblock....1..3
> # Running under perl version 5.008004 for MSWin32
> # Win32::BuildNumber 810
> # Current time local: Sat Nov 20 08:35:28 2004
> # Current time GMT:   Sat Nov 20 07:35:28 2004
> # Using Test.pm version 1.25
> # Using Apache/Test.pm version 1.17
> ok 1
> # testing : no timeout
> # expected: nonblocking
> # received: nonblocking
> ok 2
> # Failed test 3 in t\protocol\echo_nonblock.t at line 26
> # testing : timed out
> # expected: TIMEUP
> # received: should timeout
> not ok 3
> FAILED test 3
>         Failed 1/3 tests, 66.67% okay

Markus, any difference with this patch?

Index: t/protocol/echo_nonblock.t
===================================================================
RCS file: /home/cvs/modperl-2.0/t/protocol/echo_nonblock.t,v
retrieving revision 1.2
diff -u -r1.2 echo_nonblock.t
--- t/protocol/echo_nonblock.t  28 Sep 2004 22:47:22 -0000      1.2
+++ t/protocol/echo_nonblock.t  21 Nov 2004 16:53:11 -0000
@@ -21,6 +21,7 @@

  # now get a timed out request
  $expected = "TIMEUP";
+sleep 2;
  print $socket "should timeout\n";
  chomp($received = <$socket> || '');
  ok t_cmp $received, $expected, "timed out";

If it works, try to lower it to 1 sec if possible.

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message