perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [Patch mp2] remove the magicness of PerlLoadModule wrt directives
Date Tue, 09 Nov 2004 03:04:37 GMT
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> 
>> Attached is the small patch to remove the magicness of PerlLoadModule 
>> and add
>> Apache::Module::add() as discussed earlier.
> 
> excellent! a few minor comments below.
> 
>> [...]
>> +
>> +Apache::Module::add(__PACKAGE__, \@CMDS);
> 
> I suppose there is no point making those upcase anymore, since they 
> aren't special (above and below / tests + docs). What do you think?

Think it's a very good idea, and I liked Geoff's suggestion of 
@directives instead.

>> Index: src/docs/2.0/api/Apache/CmdParms.pod
> 
> [...]
> 
>>  The extra information passed through C<cmd_data> in
>> -C<L<@APACHE_MODULE_COMMANDS|docs::2.0::user::config::custom/C_cmd_data_>>.

>>
>> +C<L<@CMDS|docs::2.0::user::config::custom/C_cmd_data_>>.
> 
> 
> but it's no longer passed in cmd_data user-wise. Shouldn't it link to 
> Apache::Module::add() and the latter to cmd_data?

Yes, I guess it makes more sense that way.

> [...] 
> missing add() call?

Yup.

>> Index: src/docs/2.0/api/Apache/Const.pod
> [...]  
>> -=item * A global array C<@APACHE_MODULE_COMMANDS> for declaring the
>> -new directives and their behavior.
>> +=item * An array C<L<@CMDS|/C__CMDS_>> for declaring the new 
>> directives and their
>> +behavior.
>> +
>> +=item * A call to 
>> C<L<Apache::Module::add()|docs::2.0::api::Apache::Module/C_add_>> to

>> register the new
>> +directives with apache.
>  
> wrap the line?

Indeed.

> [...]
> 
> may be add a note that @CMDS is not a special name and any other name 
> will do?

That's a good idea. Added.

>> +=head2 Apache::Module::add()
> 
> Call it: "Activating the new directive" or "Registering ..."  or 
> something like that? Apache::Module::add() looks like an API entry, 
> which is already defined elsewhere.

"Registering the new directives" is it.

-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 
88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 
88C3A5A5

Mime
View raw message