perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [PATCH] Re: mp2 build error on Win32
Date Wed, 03 Nov 2004 20:41:19 GMT

>>You need to look for "?=" appearing in a few of the Makefiles (not the
>>top-level one).  IIRC it's coming from a TEST_VERBOSE assignment, so it 
>>might be Test::Harness that's borked?  Anyways, replacing them with "="
>>seemed to let the Win32 build go through, but some of the tests failed 
>>for me.
>>
> 
> Spot on!
> 
> Apache-Test and ModPerl-Registry Makefile's both have:
> 
> TEST_VERBOSE ?= 0
> 
> Deleting the "?" fixes it.

blarg, that was me.  from the log:

  revision 1.42
  date: 2004/10/26 01:42:14;  author: geoff;  state: Exp;  lines: +1 -1
  make sure TEST_VERBOSE respects the environment, not just the current
  shell command.

  somebody shout if ?= isn't portable

anyway, I reverted TestMM.pm back to 1.42.  the issue I was trying to fix
was that if you do

  $ make test TEST_VERBOSE=1

TEST_VERBOSE is respected.  however, if you do

  $ export TEST_VERBOSE=1
  $ make test

TEST_VERBOSE is not respected.

a minor issue, sure, but one that was nagging me.

anyway, sorry for the late response, and thanks gozer for pinging me :)

--Geoff


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message